Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JAVA_HOME #184

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Fix JAVA_HOME #184

merged 4 commits into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. Expect OpenJdk to have JAVA_HOME

    @dagguh
    dagguh committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    847f36e View commit details
    Browse the repository at this point in the history

  2. Fix JAVA_HOME in OpenJDK 

    TDD: green
    @dagguh
    dagguh committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    441ddc1 View commit details
    Browse the repository at this point in the history

  3. Fix JAVA_HOME in OpenJDK11

    @dagguh
    dagguh committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    430b517 View commit details
    Browse the repository at this point in the history

  4. Relax JAVA_HOME tests amd64/arm64 

    It was passing locally on M1 MacBook, but on CI it failed:
```
java.lang.AssertionError:
Expecting:
 <"/usr/lib/jvm/java-1.8.0-openjdk-amd64
">
to contain:
 <"/usr/lib/jvm/java-1.8.0-openjdk-arm64">

at com.atlassian.performance.tools.infrastructure.api.jvm.JdkSupport.shouldHaveJavaHomeSet(JdkSupport.kt:17)
at com.atlassian.performance.tools.infrastructure.api.jvm.OpenJdkIT.shouldHaveJavaHome(OpenJdkIT.kt:14)
```

The `SshUbuntuContainer` does not isolate the env and differs across CPU architectures.
Underneath, the Docker sniffs out the underlying arch.
    @dagguh
    dagguh committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    78ed211 View commit details
    Browse the repository at this point in the history