Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new parametrized CustomChromium #58

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Added new parametrized CustomChromium #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ Dropping a requirement of a major version of a dependency is a new contract.
### Fixed
- Use non-deprecated Kotlin stdlib. Fix [JPERF-466].

### Added
- Added parametrized `CustomChromium`.

[JPERF-466]: https://ecosystem.atlassian.net/browse/JPERF-466

## [4.14.4] - 2019-12-09
Expand Down
24 changes: 24 additions & 0 deletions ...lin/com/atlassian/performance/tools/infrastructure/api/browser/chromium/CustomChromium.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package com.atlassian.performance.tools.infrastructure.api.browser.chromium

import com.atlassian.performance.tools.infrastructure.ChromedriverInstaller
import com.atlassian.performance.tools.infrastructure.ChromiumInstaller
import com.atlassian.performance.tools.infrastructure.api.browser.Browser
import com.atlassian.performance.tools.infrastructure.ParallelExecutor
import com.atlassian.performance.tools.ssh.api.SshConnection
import java.net.URI

class CustomChromium(
private val chromiumUri: URI,
private val chromedriverUri: URI
) : Browser {
dagguh marked this conversation as resolved.
Show resolved Hide resolved

/**
* Installs chromium with specified URI
*/
override fun install(ssh: SshConnection) {
ParallelExecutor().execute(
{ ChromiumInstaller(chromiumUri).install(ssh) },
{ ChromedriverInstaller(chromedriverUri).install(ssh) }
)
}
}