master <-- JCSP-515: fixing jpt for equifax run #69
Conversation
…run' into JCSP-515-fixing-jpt-for-equifax-run
| } | ||
|
|
||
| private fun searchFilter() { | ||
| val filter = filters.recall()!! |
| import java.net.URI | ||
| import javax.json.JsonObject | ||
|
|
||
| class WorkOnSearch( |
There was a problem hiding this comment.
Nice, rich, cross-platform workflow. Well done.
| searchWithJql = SearchCloudFilter( | ||
| jira = jira, | ||
| meter = meter, | ||
| filters = similarities.filtersMemory | ||
| ), |
There was a problem hiding this comment.
I like how much the scenario differences decrease and scenario similarities increase. It gives us more and more confidence that we're comparing apples to apples 👍
| @@ -55,11 +54,6 @@ class JiraDcScenario : Scenario { | |||
| projectMemory = similarities.projectMemory, | |||
| createIssueButtons = listOf(By.id("create_link")) | |||
| ), | |||
| searchWithJql = SearchServerFilter( | |||
There was a problem hiding this comment.
These changes are already in #69. Combining multiple changes in a single PR makes it messy. Reviewers have to review the same diffs multiple times. When one gets merged the other one has to rebase/resolve conflicts. The multi-change diff is huge and hard to understand.
| @@ -43,7 +43,7 @@ class JiraPerformanceComparisonIT { | |||
| val results: List<EdibleResult> = AbruptExecutorService(newCachedThreadPool()).use { pool -> | |||
| listOf( | |||
| benchmark("a.properties", JiraDcScenario::class.java, quality, pool), | |||
| benchmark("equifax.properties", JiraCloudScenario::class.java, quality, pool) | |||
There was a problem hiding this comment.
The file names were anonymous for a reason. Please, be more careful. FYI @ysemenkov
| querryList.add("/issues/?jql=Application%20%3D%20\"Access%20Management\"%20" + | ||
| "and%20assignee%20%3D%20557057%3A68425415-a8ec-439d-a05b-0b03720dcadf%20" + | ||
| "and%20status%20in%20(Done)%20or%20assignee%20is%20empty%20" + | ||
| "and%20component%20in%20(.NET)%20AND%20\"Reporting%20Country\"%20%3D%20Canada%20" + |
There was a problem hiding this comment.
This looks like UGC. Please never commit any user generated content to the repo!
|
WRT the title and the branch name. Please, don't send any sensitive stuff to the repo. It's all open source and public. |
https://jdog.jira-dev.com/browse/JCSP-515