Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer configuration #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandorfr
Copy link
Contributor

This PR adds Visual Studio Code configuration for Remote Development.

This way you don't need to install any local dependencies beyond the Remote Development Extensions and docker.

It also enables developing on windows without the need of tweaking scripts for it.

@albertogasparin
Copy link
Collaborator

Thanks for this PR @sandorfr. I'm going to keep it for a bit until I understand where we stand on the specific editor configs. I also have some test configs for VS code that I'm not sharing. The reason is that I'm mimicking what beautiful-dnd has done (so no editor specific stuff) but I'd like to gather more opinions.
In the meantime is there any specific problem while running the repo commands in Windows?

@sandorfr
Copy link
Contributor Author

I can see reason to not include editor configs. On another hand supporting the one or two mainstream editor especially the free ones can make life of occasional contributor so much easier.

In regards to windows, compat it failed because of the usage of rm command (which is easy to solve with rimraf). But there might be other things after that and I've been through that rabbit hole. Hence my suggestion of supporting Container dev.

On a completely different subject I actually cloned this repo to write typings for typescript to have a play with it in a typescript app. You mentioned in your talk something about support for typescript in your talk, but I got distracted and I don't recall what you said exactly. If you plan to migrate to typescript or if you're interested in me contributing the typings, let me know. We can also have a quick chat at work tomorrow if you are around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants