JPERF-811: Show how flaky shouldTolerateEarlyFinish is, so that it's … #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clear that next change fixes it
pczuj
deleted the
JPERF-811-show-how-flaky-SshTest-shouldTolerateEarlyFinish-is
branch
|
The test will be fixed in #23 |
dagguh
reviewed
Jun 29, 2022
| @@ -56,10 +56,12 @@ class SshTest { | |||
| SshContainer().useSsh { sshHost -> | |||
| installPing(sshHost) | |||
|
|
|||
| val fail = sshHost.runInBackground("nonexistent-command") | |||
| val failResult = fail.stop(Duration.ofMillis(20)) | |||
| repeat(1000) { | |||
There was a problem hiding this comment.
Good change, exposes the problem more predictably 👍
|
This PR left an unmaintained branch. It's best to open PRs from forks. |
No, I believe I removed the branch. Don't see it in the picker:
I don't see any advantage and it's easier to access other's changes with vanilla git client when most of the PR branches land in the main repository. I'm open to discussion about it. Maybe I don't know about something. |
|
Ah right, it's a different branch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…clear that next change fixes it