Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #159 - Re-opening #181 to add a test and get review #195

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Closes #159 - Re-opening #181 to add a test and get review #195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0d653f
Add test
EeethB Nov 28, 2023
937b2ae
Merge branch 'main' into 159_bug_type_factor_levels
bms63 Dec 5, 2023
ab06640
Merge branch 'main' into 159_bug_type_factor_levels
elimillera Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/testthat/test-type.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,3 +280,23 @@ test_that("xportr_type: Gets warning when metadata has multiple rows with same v
# Checks that message doesn't appear when xportr.domain_name is valid
multiple_vars_in_spec_helper2(xportr_type)
})

test_that("xportr_type: Drops factor levels", {
metadata <- data.frame(
dataset = "test",
variable = c("Subj", "Param", "Val", "NotUsed"),
type = c("numeric", "character", "numeric", "character"),
format = NA
)

.df <- data.frame(
Subj = as.character(123, 456, 789),
Different = c("a", "b", "c"),
Val = factor(c("1", "2", "3")),
Param = c("param1", "param2", "param3")
)

df2 <- xportr_type(.df, metadata, "test")

expect_null(attributes(df2$Val))
})
Loading