-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #151 - Metadata includes verbose
option
#199
Conversation
0bb0ef8
to
ab82633
Compare
0a582b1
to
a0d83b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 612 627 +15
=========================================
+ Hits 612 627 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to create a test-metadata.R
file and move al the metadata related tests into that file. Just to help keep things organized and findable
Co-authored-by: Ben Straub <[email protected]>
I made this change, let me know what you think! |
Hey - @EeethB when you get a chance can you fixt these merge conflicts please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also a bit concerned about the effect of calling xportr_metadata
multiple times with different arguments.
It might overwrite previously set metadata / verbose (started a discussion on #224)
We can discuss and deal with it in that issue.
`_xportr.df_metadata_` = metadata, | ||
`_xportr.df_verbose_` = verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use quotes "
, instead of backticks
`_xportr.df_metadata_` = metadata, | |
`_xportr.df_verbose_` = verbose | |
"_xportr.df_metadata_" = metadata, | |
"_xportr.df_verbose_" = verbose |
@@ -51,5 +54,8 @@ xportr_metadata <- function(.df, metadata = NULL, domain = NULL) { | |||
|
|||
## End of common section | |||
|
|||
structure(.df, `_xportr.df_metadata_` = metadata) | |||
structure(.df, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very optional. I would think that {styler} or {lintr} didn't like this indentation
structure(.df, | |
structure( | |
.df, |
@EeethB Ping me after you fix these merge conflicts and I can take a look |
* 226_fix_xportr_write: fix/revert: metadata is no longer inferred
@EeethB I merged the
Additionally, the placement of the inferrement of the Sorry about this 😕. |
@averissimo thanks for doing all that! It looks like all the checks are passing now, @bms63 I think this is ready for one more review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thank yous @EeethB and @averissimo for helping to see this PR/issue through!!
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.
The scope of
{xportr}
{xportr}
's scope is to enable R users to write out submission compliantxpt
files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the{xportr}
team on slack or create an issue to discuss.Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.Changes Description
verbose
option toxportr_metadata()
verbose
to NULL in all other functionsverbose
value in this priority order:xportr_metadata()
_xportr.[type|length|order|label]_verbose_
Task List
styler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.vbump.yaml
CI.