New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bash): rework #1509 to recover from the preexec failure #1729

Merged

ellie merged 1 commit into atuinsh:main from akinomyoga:workaround-keybinding-preexec

Feb 17, 2024

Commits on Feb 17, 2024

fix(bash): rework atuinsh#1509 to recover from the preexec failure

In GitHub atuinsh#1509, we blocked the unintended preexec event caused by the
keybinding of Atuin.  However, with that fix, the preexec event for
the intended user command is still missing.  In this patch, we try to
manually run the preexec hook when we detected the unintended preexec
(which means the missing intended preexec).

References:

atuinsh#1509
https://forum.atuin.sh/t/atuin-bash-and-ble-sh/175
atuinsh#1003 (comment)
atuinsh#1727
atuinsh#1728

akinomyoga committed Feb 17, 2024