Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dotfiles): support syncing shell/env vars #1977

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

ellie
Copy link
Member

@ellie ellie commented Apr 24, 2024

There's a bunch of duplication here!

I'd also like to support syncing shell "snippets", aka just bits of shell config that don't fit into the structure here. Potentially special handling for PATH too.

Rather than come up with some abstraction in the beginning, which inevitably will not fit future uses, I'm duplicating code for now.

Once all the functionality is there, I can tidy things up and sort a proper abstraction out.

Something in atuin-client for map/list style synced structures would probably work best.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

There's a bunch of duplication here!

I'd also like to support syncing shell "snippets", aka just bits of
shell config that don't fit into the structure here. Potentially special
handling for PATH too.

Rather than come up with some abstraction in the beginning, which
inevitably will not fit future uses, I'm duplicating code _for now_.

Once all the functionality is there, I can tidy things up and sort a
proper abstraction out.

Something in atuin-client for map/list style synced structures would
probably work best.
@ellie ellie merged commit d020c81 into main Apr 25, 2024
17 checks passed
@ellie ellie deleted the ellie/dotfiles-vars branch April 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant