-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to cargo dist for releases #2085
Merged
Merged
Commits on Jun 4, 2024
-
chore: switch to cargo dist for releases
From https://axo.dev cargo-dist handles building releases far better than we can, and do so for several large projects now. We will need to change our install script to use the cargo-dist installer. Historically, we have used the system package manager wherever possible. Once switched to the new installer, this will no longer be the case. If the user wishes to use their package manager, and Atuin is maintained there, then they can choose to do so. This way, we can ensure that users are running a known build, can easily uninstall (just delete the atuin dir), easily update, etc. Builds will use our lockfile, and can have their checksum verified. Later, I'd like to introduce build signing. As Axo are focused on release engineering, they will likely have resolved many more issues than we have - libc versions, etc. I'm not particularly happy with our response of "just use your package manager", as many users seem to have difficulty there. It's unclear what our installer has done, as this behaviour varies massively across systems. It's also unclear how some package maintainers may have patched things I'm hoping that some better release tooling will lead to more confidence in the process, and therefore more frequent releases. Uninstall clarity: #111, #372, #640, #1485, #1546, #2049, #1529
Configuration menu - View commit details
-
Copy full SHA for 5e1498f - Browse repository at this point
Copy the full SHA 5e1498fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2a526c - Browse repository at this point
Copy the full SHA c2a526cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 864a657 - Browse repository at this point
Copy the full SHA 864a657View commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b4387f7 - Browse repository at this point
Copy the full SHA b4387f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8d44b - Browse repository at this point
Copy the full SHA 3a8d44bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e85e7e0 - Browse repository at this point
Copy the full SHA e85e7e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35675b6 - Browse repository at this point
Copy the full SHA 35675b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ce7d88 - Browse repository at this point
Copy the full SHA 4ce7d88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 733c74d - Browse repository at this point
Copy the full SHA 733c74dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07d6516 - Browse repository at this point
Copy the full SHA 07d6516View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.