Add a parameter to the sync to specify the download/upload page #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m42e
force-pushed
the
custom-sync-page-count
branch
4 times, most recently
from
9d2a180 to
8e4280a
Compare
m42e
force-pushed
the
custom-sync-page-count
branch
from
8e4280a to
0b69795
Compare
ellie
reviewed
Oct 7, 2024
| @@ -19,6 +19,11 @@ pub struct Pull { | |||
| /// This will first wipe the local store, and then download all records from the remote | |||
| #[arg(long, default_value = "false")] | |||
| pub force: bool, | |||
|
|
|||
| /// Page Size | |||
| /// How many records to upload at once. Defaults to 100 | |||
There was a problem hiding this comment.
Suggested change
| /// How many records to upload at once. Defaults to 100 | |
| /// How many records to download at once. Defaults to 100 |
|
I'd be pretty concerned if users would want a page_size to reduce the value from 100 tbh, it should be plenty small enough that a 413 isn't a problem. Wanting to increase it for a potentially faster sync might make sense, though Is this an issue you've been hitting? |
|
Yes, I had some expanded command lines with quite a lot of files in my history which caused a hang during the upload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter to change the upload/download page size, this could help if one gets a '413' in a selfhosted scenario.
Checks