Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new backend interface #306

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Switch to new backend interface #306

merged 4 commits into from
Oct 16, 2023

Conversation

frankenjoe
Copy link
Collaborator

@frankenjoe frankenjoe commented May 9, 2023

Apply necessary changes to audb in order to use the new backend interface that will be introduced with audackend>=1.0.0, see audeering/audbackend#76.
This does not change how files are stored on Artifatory hosts as we use the legacy backend option there.

Building the docs and running the docstring examples are temporary disabled until we have a published version of emodb with the new structure

In the Authentication section we now link to audbackend.Artifactory:

image

@frankenjoe frankenjoe changed the base branch from main to dev May 9, 2023 14:13
@frankenjoe
Copy link
Collaborator Author

In audeering/audbackend#76 (comment) a migration plan is proposed that would allow us to also re-enable the emodb related tests here without affecting the tests of the main branch.

@frankenjoe frankenjoe changed the title WIP: Switch to new backend structure (rebased) WIP: Switch to new backend structure May 9, 2023
tests/test_load.py Outdated Show resolved Hide resolved
audb/core/api.py Outdated Show resolved Hide resolved
tests/test_load.py Outdated Show resolved Hide resolved
@frankenjoe
Copy link
Collaborator Author

Locally all tests are passing again, but it seems that in the CI job it cannot read the credentials.

@frankenjoe
Copy link
Collaborator Author

@hagenw any idea why? ARTIFACTORY_USERNAME and ARTIFACTORY_API_KEY should be set, right?

@frankenjoe
Copy link
Collaborator Author

@hagenw any idea why? ARTIFACTORY_USERNAME and ARTIFACTORY_API_KEY should be set, right?

Of course not, because anonymous access should. Works after applying another fix in audeering/audbackend#130.

@frankenjoe frankenjoe changed the title WIP: Switch to new backend structure Switch to new backend structure May 15, 2023
@frankenjoe
Copy link
Collaborator Author

All tests are passing again, so it seems with audeering/audbackend#130 we finally found a solution that does not require any change to our existing repositories and still allows us to switch to the new backend interface :)

setup.cfg Outdated Show resolved Hide resolved
@frankenjoe frankenjoe changed the title Switch to new backend structure Switch to new backend interface May 15, 2023
@hagenw
Copy link
Member

hagenw commented Sep 18, 2023

audeering/audbackend#132 seems to me also a remaining blocker.

With audbackend 0.3.17 and the current main branch of audb, audb.available() takes 36 s for me over VPN, using the dev branch of audbackend and this branch of audb it takes 151 s.

@frankenjoe
Copy link
Collaborator Author

audeering/audbackend#132 seems to me also a remaining blocker.

With audbackend 0.3.17 and the current main branch of audb, audb.available() takes 36 s for me over VPN, using the dev branch of audbackend and this branch of audb it takes 151 s.

I tweaked it a bit and now it takes 11s on my machine through VPN.

@hagenw
Copy link
Member

hagenw commented Sep 18, 2023

Very nice, for me it now took 8 s, so now you even improved on the solution in main.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #306 (ddec948) into main (ca1a21c) will not change coverage.
The diff coverage is 100.0%.

Files Coverage Δ
audb/core/api.py 100.0% <100.0%> (ø)
audb/core/load.py 100.0% <100.0%> (ø)
audb/core/load_to.py 100.0% <ø> (ø)
audb/core/publish.py 100.0% <100.0%> (ø)
audb/core/utils.py 100.0% <100.0%> (ø)

@hagenw hagenw changed the base branch from dev to main October 16, 2023 13:37
@hagenw
Copy link
Member

hagenw commented Oct 16, 2023

Everything is still working, so I will merge this.

@hagenw hagenw merged commit 900e3be into main Oct 16, 2023
9 checks passed
@hagenw hagenw deleted the new-backend-2 branch October 16, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants