Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on audeer>=2.0.0 #348

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Depend on audeer>=2.0.0 #348

merged 9 commits into from
Jan 25, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 23, 2024

This updates the code to work with the changes to audeer.path() introduced in audeer 2.0.0.

It ensures that cache_root and db_root point always to the real path, by using audeer.path(..., follow_symlink=True) when first assigning them, whereby it assumes that audformat.Database.root returns already a real path.

The tests are cleaned up by using audeer.mkdir("a", "b") instead of audeer.mkdir(audeer.path("a", "b")), and the same for audeer.rmdir() and audeer.touch().

@hagenw hagenw marked this pull request as draft January 23, 2024 13:34
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16e8e6a) 100.0% compared to head (4cfc774) 100.0%.

Additional details and impacted files
Files Coverage Δ
audb/core/api.py 100.0% <100.0%> (ø)
audb/core/cache.py 100.0% <100.0%> (ø)
audb/core/load.py 100.0% <100.0%> (ø)
audb/core/load_to.py 100.0% <100.0%> (ø)
audb/core/utils.py 100.0% <100.0%> (ø)

@hagenw hagenw marked this pull request as ready for review January 25, 2024 09:06
@hagenw hagenw merged commit d151f10 into main Jan 25, 2024
9 checks passed
@hagenw hagenw deleted the audeer-2.0 branch January 25, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant