CI: enhance name of test jobs #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianGeng
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Review
This for me indeed facilitates understanding of the matrix.
So you skip the pandas installation when the matrix entry is empty for pandas.
I also assume that the entry
- os: ubuntu-latest
python-version: '3.10'
is a default ubuntu entry that does not fix a specific version of pandas and will resolve to the latest version.
I also like that 3.11 is now part of the matrix.
Approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on the names of the CI jobs by changing them from
to
Which means we display
pandas==<version>only if a differentpandasversion is selected, and removetestsfrom the display string.