Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_vehicle_msgs): add autoware_vehicle_msgs #78

Merged

Conversation

beginningfan
Copy link
Contributor

Description

Porting autoware_vehicle_msgs code from autoware_auto_vehicle_msgs

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beginningfan beginningfan changed the title add autoware_vehicle_msgs feat(autoware_vehicle_msgs): add autoware_vehicle_msgs Dec 11, 2023
@cyn-liu cyn-liu merged commit 2f4a0be into autowarefoundation:main Dec 12, 2023
8 of 9 checks passed
@xmfcx
Copy link
Collaborator

xmfcx commented Dec 25, 2023

Is there a reason for why these messages and their "Report" counterparts were not ported?

It is ok that VehicleStateCommand was not ported.

Related: https://github.com/orgs/autowarefoundation/discussions/4082

@beginningfan
Copy link
Contributor Author

beginningfan commented Dec 25, 2023

@xmfcx Those msgs are not used in autoware now.
In my first commit, I ported almosted all the msgs. But then I deleted the useless msgs.

@xmfcx
Copy link
Collaborator

xmfcx commented Dec 25, 2023

Ok thanks 👍 , we can add them back when we need them. For now we don't need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants