New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate CI #828

Merged

patrick-ogrady merged 9 commits into main from conditional-run

May 1, 2024

Collaborator

richardpringle commented Apr 9, 2024 •

edited

Loading

Run all the Go CI as part of a single workflow with managed job dependencies.
Also included is

abstracting local actions for re-use in jobs

This completely removes the need for the run all ci label and instead makes the "heavier" jobs dependent on most other things passing first.

richardpringle added run all ci wasmlanche and removed wasmlanche run all ci labels

richardpringle force-pushed the conditional-run branch from 1bb50a2 to e38d598 Compare

April 9, 2024 14:47

richardpringle marked this pull request as ready for review

April 10, 2024 12:04

richardpringle requested a review from patrick-ogrady as a code owner

April 10, 2024 12:04

richardpringle changed the title ~~Just testing actions out~~ Make sure that all of CI is run before merging

richardpringle self-assigned this

richardpringle force-pushed the conditional-run branch from e7f3bc0 to 34f57b1 Compare

April 29, 2024 15:11

richardpringle added run all ci and removed run all ci labels

richardpringle force-pushed the conditional-run branch 2 times, most recently from 34b6887 to a409edd Compare

April 29, 2024 22:25

richardpringle commented

View reviewed changes

.github/workflows/codeql-analysis.yml

-                  - name: Perform CodeQL Analysis
-                    uses: github/codeql-action/analyze@v2
+                    - name: Perform CodeQL Analysis
+                      uses: github/codeql-action/analyze@v2

Collaborator Author

richardpringle Apr 29, 2024

My formatter did all this... I can back this change out if you want

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated

Comment on lines 70 to 75

+                finished-all-hypersdk-tests:
+                  runs-on: ubuntu-latest
+                  needs: [mock_gen, hypersdk-lint, go_mod_tidy, hypersdk-unit-tests]
+                  steps:
+                    - name: Finished all HyperSDK tests
+                      run: echo "Finished all HyperSDK tests"

Collaborator Author

richardpringle Apr 29, 2024

This is a bit of a hack. Otherwise I have to list all the jobs every time.

Contributor

patrick-ogrady May 1, 2024

clever lol

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml

+                # TokenVM
+                tokenvm-lint:
+                  runs-on: ubuntu-latest

Collaborator Author

richardpringle Apr 29, 2024

This used to run on a labelled machine, do we need that?

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated

+                      run: scripts/build.sh
+                tokenvm-unit-tests:
+                  runs-on: ubuntu-latest

Collaborator Author

richardpringle Apr 29, 2024

This used to run on a labelled machine, do we need that? I'm assuming we don't since the timeout is 10 instead of 25, but easy to put back

Collaborator Author

richardpringle Apr 30, 2024

Was running it on the bigger machine related to golang/go#57328?

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated

+                # TokenVM
+                tokenvm-lint:
+                  runs-on: ubuntu-latest
+                  needs: [finished-all-hypersdk-tests]

Collaborator Author

richardpringle Apr 29, 2024

Could probably run the linter without waitng, right?

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated Show resolved Hide resolved

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated

+                # MorpheusVM
+                morpheusvm-lint:
+                  needs: [finished-all-hypersdk-tests]

Collaborator Author

richardpringle Apr 29, 2024

We could probably run this too

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated Show resolved Hide resolved

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated Show resolved Hide resolved

richardpringle commented

View reviewed changes

.github/workflows/hypersdk-ci.yml Outdated Show resolved Hide resolved

richardpringle added 6 commits

April 30, 2024 11:49


          Add rust-ci local github-action

03ed08f


          Abstract install-go action

bdbf32e


          Centralize Go install parameters

cd9e5c5


          Consolidate CI

ab8bb22


          Comment out code coverage

929dbc2


          Finish centralizing the Go installation for CI

d56093f

richardpringle force-pushed the conditional-run branch from 5d706fa to d56093f Compare

April 30, 2024 15:50

richardpringle added 2 commits

April 30, 2024 13:28


          Handle releases

a663017


          Fix passing secret to release-actions

2b47571

richardpringle changed the title ~~Make sure that all of CI is run before merging~~ Consolidate CI


          [ci] Small Tweaks (#875)

0ec50cd

* nits

* remove labels

patrick-ogrady merged commit 5fb26c1 into main

9 checks passed

patrick-ogrady deleted the conditional-run branch

May 1, 2024 12:13

iFrostizz pushed a commit to iFrostizz/hypersdk that referenced this pull request


          Consolidate CI (ava-labs#828)

8ce44c9

* Add rust-ci local github-action

* Abstract install-go action

* Centralize Go install parameters

* Consolidate CI

* Comment out code coverage

* Finish centralizing the Go installation for CI

* Handle releases

* Fix passing secret to release-actions

* [ci] Small Tweaks (ava-labs#875)

* nits

* remove labels

---------

Co-authored-by: Patrick O'Grady <[email protected]>

richardpringle added a commit that referenced this pull request


          [x/programs] Remove SmartPtr and HostPtr (#872)

3d8ddec

* support program passing in param

* fix inter-program interaction

* update fixture

* keep using `SmartPtr` for now

* remove the need of a new Param type

* lint

* remove param

* fix nits

* remove whitespace

* stop using SmartPtr

* fix tests

* Cached state values in the program state (#840)

* add cache

* implement cache reads

* actually cache reads

* implement cache delete and handle borsch errors

* use only one cache map

* remove flushed bool

* root of transactions by stateless merkledb

* make root generation a function

* preallocate memory for merkle array and consumebytes flag

* add <*.code-workspace> to .gitignore and remove it from git commit

* move root generation func to merkle package, tx root by items of [txID + result]

* rebase & blk marshal/unmarshal & merkleroot to ids.ID

* write benches for the merkle package

* use crypto/rand, fix var name, report allocs

* put the 10k bench back

* pass config by parameter

* happy clippy

* borrow V

* add TODO

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "put the 10k bench back"

This reverts commit 058d7e7.

* Revert "use crypto/rand, fix var name, report allocs"

This reverts commit 214005b.

* Revert "write benches for the merkle package"

This reverts commit 07993bf.

* Revert "rebase & blk marshal/unmarshal & merkleroot to ids.ID"

This reverts commit 7442836.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "add <*.code-workspace> to .gitignore and remove it from git commit"

This reverts commit ce00289.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* merge main!

* merge imports

---------

Co-authored-by: bianyuanop <[email protected]>
Co-authored-by: Richard Pringle <[email protected]>

* stop using SmartPtr

* Cached state values in the program state (#840)

* add cache

* implement cache reads

* actually cache reads

* implement cache delete and handle borsch errors

* use only one cache map

* remove flushed bool

* root of transactions by stateless merkledb

* make root generation a function

* preallocate memory for merkle array and consumebytes flag

* add <*.code-workspace> to .gitignore and remove it from git commit

* move root generation func to merkle package, tx root by items of [txID + result]

* rebase & blk marshal/unmarshal & merkleroot to ids.ID

* write benches for the merkle package

* use crypto/rand, fix var name, report allocs

* put the 10k bench back

* pass config by parameter

* happy clippy

* borrow V

* add TODO

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "put the 10k bench back"

This reverts commit 058d7e7.

* Revert "use crypto/rand, fix var name, report allocs"

This reverts commit 214005b.

* Revert "write benches for the merkle package"

This reverts commit 07993bf.

* Revert "rebase & blk marshal/unmarshal & merkleroot to ids.ID"

This reverts commit 7442836.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "add <*.code-workspace> to .gitignore and remove it from git commit"

This reverts commit ce00289.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* merge main!

* merge imports

---------

Co-authored-by: bianyuanop <[email protected]>
Co-authored-by: Richard Pringle <[email protected]>

* [x/programs] safe wrapper around C ffi interface (#869)

* macro skeleton

* write macro for ffi-safe bindings

* avoid panicking todo!

Signed-off-by: Franfran <[email protected]>

* remove unused arms

---------

Signed-off-by: Franfran <[email protected]>

* support program passing in param

* keep using `SmartPtr` for now

* remove the need of a new Param type

* lint

* stop using SmartPtr

* fix tests

* back off file

* handle put and delete return as a status and remove the `SmartPointer`

* cargo fmt

* fix test

* pass only context ptr as i32

* fix token test

* lint

* remove ignored lint

* update fixtures

* move `CPointer` from `program` to `memory`

* update fixutes to release

* cargo fmt

* Consolidate CI (#828)

* Add rust-ci local github-action

* Abstract install-go action

* Centralize Go install parameters

* Consolidate CI

* Comment out code coverage

* Finish centralizing the Go installation for CI

* Handle releases

* Fix passing secret to release-actions

* [ci] Small Tweaks (#875)

* nits

* remove labels

---------

Co-authored-by: Patrick O'Grady <[email protected]>

* Update vm-release.yml (#876)

Signed-off-by: Richard Pringle <[email protected]>

* fix inter-program interaction

* keep using `SmartPtr` for now

* lint

* remove param

* fix nits

* stop using SmartPtr

* fix tests

* Cached state values in the program state (#840)

* add cache

* implement cache reads

* actually cache reads

* implement cache delete and handle borsch errors

* use only one cache map

* remove flushed bool

* root of transactions by stateless merkledb

* make root generation a function

* preallocate memory for merkle array and consumebytes flag

* add <*.code-workspace> to .gitignore and remove it from git commit

* move root generation func to merkle package, tx root by items of [txID + result]

* rebase & blk marshal/unmarshal & merkleroot to ids.ID

* write benches for the merkle package

* use crypto/rand, fix var name, report allocs

* put the 10k bench back

* pass config by parameter

* happy clippy

* borrow V

* add TODO

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "put the 10k bench back"

This reverts commit 058d7e7.

* Revert "use crypto/rand, fix var name, report allocs"

This reverts commit 214005b.

* Revert "write benches for the merkle package"

This reverts commit 07993bf.

* Revert "rebase & blk marshal/unmarshal & merkleroot to ids.ID"

This reverts commit 7442836.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "add <*.code-workspace> to .gitignore and remove it from git commit"

This reverts commit ce00289.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* merge main!

* merge imports

---------

Co-authored-by: bianyuanop <[email protected]>
Co-authored-by: Richard Pringle <[email protected]>

* stop using SmartPtr

* Cached state values in the program state (#840)

* add cache

* implement cache reads

* actually cache reads

* implement cache delete and handle borsch errors

* use only one cache map

* remove flushed bool

* root of transactions by stateless merkledb

* make root generation a function

* preallocate memory for merkle array and consumebytes flag

* add <*.code-workspace> to .gitignore and remove it from git commit

* move root generation func to merkle package, tx root by items of [txID + result]

* rebase & blk marshal/unmarshal & merkleroot to ids.ID

* write benches for the merkle package

* use crypto/rand, fix var name, report allocs

* put the 10k bench back

* pass config by parameter

* happy clippy

* borrow V

* add TODO

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "put the 10k bench back"

This reverts commit 058d7e7.

* Revert "use crypto/rand, fix var name, report allocs"

This reverts commit 214005b.

* Revert "write benches for the merkle package"

This reverts commit 07993bf.

* Revert "rebase & blk marshal/unmarshal & merkleroot to ids.ID"

This reverts commit 7442836.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "add <*.code-workspace> to .gitignore and remove it from git commit"

This reverts commit ce00289.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* Revert "pass config by parameter"

This reverts commit 4aec589.

* Revert "move root generation func to merkle package, tx root by items of [txID + result]"

This reverts commit e551960.

* Revert "preallocate memory for merkle array and consumebytes flag"

This reverts commit 68e49b6.

* Revert "make root generation a function"

This reverts commit aa44f97.

* merge main!

* merge imports

---------

Co-authored-by: bianyuanop <[email protected]>
Co-authored-by: Richard Pringle <[email protected]>

* [x/programs] safe wrapper around C ffi interface (#869)

* macro skeleton

* write macro for ffi-safe bindings

* avoid panicking todo!

Signed-off-by: Franfran <[email protected]>

* remove unused arms

---------

Signed-off-by: Franfran <[email protected]>

* keep using `SmartPtr` for now

* fix tests

* handle put and delete return as a status and remove the `SmartPointer`

* cargo fmt

* move `CPointer` from `program` to `memory`

* cargo fmt

---------

Signed-off-by: Franfran <[email protected]>
Signed-off-by: Richard Pringle <[email protected]>
Co-authored-by: bianyuanop <[email protected]>
Co-authored-by: Richard Pringle <[email protected]>
Co-authored-by: Patrick O'Grady <[email protected]>

iFrostizz pushed a commit that referenced this pull request


          Consolidate CI (#828)

* Add rust-ci local github-action

* Abstract install-go action

* Centralize Go install parameters

* Consolidate CI

* Comment out code coverage

* Finish centralizing the Go installation for CI

* Handle releases

* Fix passing secret to release-actions

* [ci] Small Tweaks (#875)

* nits

* remove labels

---------

Co-authored-by: Patrick O'Grady <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet