-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix date time creation when microtime has no decimals #35
Fix date time creation when microtime has no decimals #35
Conversation
@estevejm Partners we have many exceptions from the test and several from the production Could you investigate this issue and fixed this in near time |
@estevejm Hi, we still get exceptions. We are waiting the merge. |
@TkachukRuslan I don't have write access, hence I can't merge it. I think @anyarms is one of the maintainers... |
I'm no longer with Avalara, so I don't have write access anymore - sorry! |
@JanzenMark |
You should probably just use a fork until this is merged into the main repo. On 30 Sep 2016 5:44 pm, "TkachukRuslan" [email protected] wrote:
|
I opened a case with Avalara support to start watching this repo again. We will see if that request gets answered or not. EDIT: I recommend others doing the same. More people will bring more attention to this. I am currently using a fork I made of this repo to get around this. |
@skylord123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine for microtime issue. Please push the code to Mater branch.
@TkachukRuslan The code is now merged in Master branch. |
Hi All. Thank you for a feedback. I have one more issue which doesn't have fix result from developers end. Let me know when the issue will be fixed ? Waiting а marge in master branch. Waiting your response. Ruslan Tkachuk On Mon, Nov 7, 2016 at 2:09 PM, Rahul Aggarwal [email protected]
|
Hi @TkachukRuslan , We are reviewing all the changes mentioned at #33 These should be done by 18th Nov. We'll update here as it is done. Thanks, |
Hi Vijay, Could you please tell us how many time do you need to do with this ? We would like to finish soon because our clients are waiting the fixes. Thank you Ruslan Tkachuk On Tue, Nov 8, 2016 at 2:50 PM, Vijay Nalawade [email protected]
|
Hi @TkachukRuslan , Sorry for the delay. We've taken this task on priority & will merge it by 18th Nov. Thanks, |
Hi, Vijay Thank you for feedback. Ruslan Tkachuk On Wed, Nov 9, 2016 at 4:47 PM, Vijay Nalawade [email protected]
|
Hi @TkachukRuslan, We've updated pull requests to master branch. Thanks, |
Hi All Thank you for updates. Ruslan Tkachuk On Thu, Nov 17, 2016 at 4:38 PM, Vijay Nalawade [email protected]
|
This PR fixes issue discussed in #30