Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date time creation when microtime has no decimals #35

Merged

Conversation

estevejm
Copy link
Contributor

@estevejm estevejm commented Sep 2, 2016

This PR fixes issue discussed in #30

@TkachukRuslan
Copy link

@estevejm
@bartkamphuis
@shieldo

Partners we have many exceptions from the test and several from the production
http://clip2net.com/s/3CbwbTn

Could you investigate this issue and fixed this in near time

@TkachukRuslan
Copy link

@estevejm
@bartkamphuis
@shieldo

Hi, we still get exceptions. We are waiting the merge.

@estevejm
Copy link
Contributor Author

@TkachukRuslan I don't have write access, hence I can't merge it.

I think @anyarms is one of the maintainers...

@TkachukRuslan
Copy link

@anyarms
@estevejm
Partners if the issue was fixed please merge it.

@anyarms
Copy link

anyarms commented Sep 26, 2016

I'm no longer with Avalara, so I don't have write access anymore - sorry!
@JanzenMark can you track down the right person to review this PR?

@TkachukRuslan
Copy link

@JanzenMark
Can you please know us the terms when will you merge it I mean the "merge" not dev merge
Thank you

@shieldo
Copy link
Contributor

shieldo commented Sep 30, 2016

You should probably just use a fork until this is merged into the main repo.

On 30 Sep 2016 5:44 pm, "TkachukRuslan" [email protected] wrote:

@JanzenMark https://github.com/JanzenMark
Can you please know us the terms when will you merge it I mean the "merge"
not dev merge
Thank you


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF8AEz1KMQW9l6sOczeOgkOchzRekXvks5qvS5MgaJpZM4JzhEC
.

@skylord123
Copy link
Contributor

skylord123 commented Oct 14, 2016

I opened a case with Avalara support to start watching this repo again. We will see if that request gets answered or not.

EDIT: I recommend others doing the same. More people will bring more attention to this. I am currently using a fork I made of this repo to get around this.

@TkachukRuslan
Copy link

@skylord123
Thank you. Please let us know when this issue will be merged in master.

Copy link
Contributor

@vijaynalawade-avalara vijaynalawade-avalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine for microtime issue. Please push the code to Mater branch.

@rahul-aggarwal-avalara rahul-aggarwal-avalara merged commit a313058 into avadev:master Nov 7, 2016
@rahul-aggarwal-avalara
Copy link
Contributor

@TkachukRuslan The code is now merged in Master branch.

@TkachukRuslan
Copy link

Hi All.

Thank you for a feedback.

I have one more issue which doesn't have fix result from developers end.
Please follow to #31

Let me know when the issue will be fixed ? Waiting а marge in master branch.

Waiting your response.

Ruslan Tkachuk
Project Manager
Net-Craft.com

On Mon, Nov 7, 2016 at 2:09 PM, Rahul Aggarwal [email protected]
wrote:

@TkachukRuslan https://github.com/TkachukRuslan The code is now merged
in Master branch.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATYYBhK-vDkk2tC6XW2lhyiORHeBeapeks5q7xTfgaJpZM4JzhEC
.

@vijaynalawade-avalara
Copy link
Contributor

vijaynalawade-avalara commented Nov 8, 2016

Hi @TkachukRuslan ,

We are reviewing all the changes mentioned at #33

These should be done by 18th Nov.

We'll update here as it is done.

Thanks,
Vijay

@TkachukRuslan
Copy link

Hi Vijay,

Could you please tell us how many time do you need to do with this ?

We would like to finish soon because our clients are waiting the fixes.

Thank you

Ruslan Tkachuk
Project Manager
Net-Craft.com

On Tue, Nov 8, 2016 at 2:50 PM, Vijay Nalawade [email protected]
wrote:

Hi @TkachukRuslan https://github.com/TkachukRuslan ,

We are reviewing all the changes mentioned at #33
#33

These should be done by 18th Oct.

We'll update here as it is done.

Thanks,
Vijay


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATYYBlZKdxU1P5bFvIDI1zgJ310MfTQ-ks5q8HACgaJpZM4JzhEC
.

@vijaynalawade-avalara
Copy link
Contributor

Hi @TkachukRuslan ,

Sorry for the delay. We've taken this task on priority & will merge it by 18th Nov.

Thanks,
Vijay

@TkachukRuslan
Copy link

Hi,

Vijay

Thank you for feedback.
We will be waiting updates from your end till 18th Nov or earlier.
Thank you

Ruslan Tkachuk
Project Manager
Net-Craft.com

On Wed, Nov 9, 2016 at 4:47 PM, Vijay Nalawade [email protected]
wrote:

Hi @TkachukRuslan https://github.com/TkachukRuslan ,

Sorry for the delay. We've taken this task on priority & will merge it by
18th Nov.

Thanks,
Vijay


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATYYBrbXTUbhjT-LRELkT1dnN73v4vmRks5q8d0JgaJpZM4JzhEC
.

@vijaynalawade-avalara
Copy link
Contributor

Hi @TkachukRuslan,

We've updated pull requests to master branch.

Thanks,
Vijay

@TkachukRuslan
Copy link

Hi All

Thank you for updates.

Ruslan Tkachuk
Project Manager
Net-Craft.com

On Thu, Nov 17, 2016 at 4:38 PM, Vijay Nalawade [email protected]
wrote:

Hi @TkachukRuslan https://github.com/TkachukRuslan,

We've updated pull requests to master branch.

Thanks,
Vijay


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATYYBpnctHgaa8A8wybvlwHExOcrvEB7ks5q_GbOgaJpZM4JzhEC
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants