Updated Tests and Updated GuzzleHttp Version to 7.0 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the test to expect an Exception instead of throwing an unhandled error. Added SANDBOX_USERNAME and SANDBOX_PASSWORD to the phpunit.xml so that the tests can be used. Added a README note on how to run the tests.
Tests are passing correctly.
|
FYI you should think of doing a version bump of your minimum PHP version. PHP 5.6 is no longer supported and is out of date. https://www.php.net/supported-versions.php |
Closed
|
@contygm any chance we could get this update fast tracked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuzzleHttp is required in quite a few widely used packages in the PHP ecosystem, in particular Laravel 8.0. While trying to update my application to laravel 8.0 I noticed their were dependency issues with AvaTax-REST-V2-PHP-SDK. I updated the GuzzleHttp version to 7.0, and I also went ahead and fixed the tests so that they would pass correctly. There is also the addition of environment variables in the phpunit.xml so that testers can test against their own sandbox accounts.