Fix regex for filtering credentials from logs #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsirius
changed the title
|
Looks like CI is no longer running and will need to migrate from travis-ci.org to travis-ci.com. |
starsirius
force-pushed
the
fix-logging-credentials
branch
2 times, most recently
from
6d94c28
to
bb25e4d
Compare
|
@shilpakhanal I see you are the most recent contributor to this project. We're in the process of integrating the SDK with our app. Do you mind helping us get this PR reviewed and hopefully merged (or directing us to the right person/process)? Thank you! 🙏 |
Update AvaTax to the latest version
The ending "=" character of a base64 encoded string is padding. When the input length is a multiple of three (which is the case for our account id and license key), the output would not have the padding character. This results in our credentials not being filtered in the logs. This fixes the regex by removing the incorrect assumption. https://en.wikipedia.org/wiki/Base64#Output_padding
starsirius
force-pushed
the
fix-logging-credentials
branch
from
bb25e4d
to
d2c381a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ending "=" character of a base64 encoded string is padding. When the input length is a multiple of three (which is the case for our account id and license key pair), the output would not have the padding character. This results in our credentials not being filtered in the logs.
This fixes the regex by removing the incorrect assumption.