Do not touch other tables #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marynychsv @virtual97, could you review this PR? |
|
Hello @ihor-sviziev , We have created a ticket based on your report. Thank you. |
|
This PR helped resolve an issue where I was unable to process orders that were paid with Amazon Pay, leading to 500 errors |
|
@virtual97 any updates? |
|
@virtual97 Any update here?! |
|
Maybe @avl-asheesh-singh @nirav-patel-avalara can review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExtensionAttributesPersistencePluginplugin parses theextension_attributes.xmlfile and tries to add values to/delete from it. But not the only avatax extension adding such extension attributes that we should join. In my case, the avatax extension was removing data from the table from another module.To prevent such an issue - I added a check for prefix. If the table name is NOT starting from avatax - we skip processing it so that other extensions won't be affected.