Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - Default Billing address is used for virtual quote, regardl… #40

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vpodorozh
Copy link

Default Billing address is used for a virtual quote, regardless billing address has been already changed/selected.

Steps to reproduce:

  • log in
  • create 2 address - first address is default and has 21% tax, scond address has 0% tax;
  • add virtual product to cart
  • got to checkout
  • select payment method and choose second address - 0% is shown, which is correct
  • refresh checkout page

Expected result:

  • second address is shown
  • second address is used as billing for quote in database
  • 0% tax percent is used

Actual result:

  • second address is shown
  • first address is used as billing for quote in database
  • 21% tax percent is used (from first address)

Solution

Remove observer \ClassyLlama\AvaTax\Observer\CalculateVirtualOrder::execute as it does zero valuable work.
The billing address is already created (from the default address) and used in Magento on quote initiation phase.
Moreover, this observer was updated last time 3 years ago - so it looks like an outdated workaround.

…ess billing address has been already changed/selected.
@virtual97
Copy link
Contributor

Hello @vpodorozh ,

We have created a ticket based on your report.
AVASUP-1135: Default Billing address is used for virtual quote, regardl…
We will keep you posted.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants