[bugfix] - Default Billing address is used for virtual quote, regardl… #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Billing address is used for a virtual quote, regardless billing address has been already changed/selected.
Steps to reproduce:
first address
is default and has 21% tax,scond address
has 0% tax;second address
- 0% is shown, which is correctExpected result:
second address
is shownsecond address
is used as billing for quote in databaseActual result:
second address
is shownfirst address
is used as billing for quote in databasefirst address
)Solution
Remove observer
\ClassyLlama\AvaTax\Observer\CalculateVirtualOrder::execute
as it does zero valuable work.The billing address is already created (from the default address) and used in Magento on quote initiation phase.
Moreover, this observer was updated last time 3 years ago - so it looks like an outdated workaround.