Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving method signature issues with Adobe Commerce 2.4.4 #44

Open
wants to merge 1 commit into
base: release/2.2.10
Choose a base branch
from
Open

Resolving method signature issues with Adobe Commerce 2.4.4 #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Model/Logger/FileHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ protected function initializeRotatingLogs($filePath)
* @param array $record
* @return Boolean
*/
public function isHandling(array $record)
public function isHandling(array $record): bool
{
return $this->avaTaxConfig->isModuleEnabled() &&
$this->avaTaxConfig->getLogFileEnabled() &&
Expand All @@ -132,7 +132,7 @@ public function isHandling(array $record)
* @param $record array
* @return void
*/
public function write(array $record)
public function write(array $record): void
{
// Filter the log details
if ($this->avaTaxConfig->getLogFileDetail() == LogDetail::MINIMAL && $record['level'] >= Logger::WARNING) {
Expand Down