Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate type key error while doing setup:upgrade #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sippsolutions
Copy link

@sippsolutions sippsolutions commented Dec 23, 2022

Currently setup:upgrade is not possible within Magento 2.4.5-p1:

$ bin/magento s:up                                                                          

More than one node matching the query: /config/type[@name='Magento\Framework\View\Element\UiComponent\DataProvider\CollectionFactory'], Xml is: <?xml version="1.0"?>
<!--
/*
 * Avalara_BaseProvider
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is bundled with this package in the file LICENSE.txt.
 * It is also available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * @copyright Copyright (c) 2021 Avalara, Inc
 * @license    http: //opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 */
-->
...

@sippsolutions
Copy link
Author

@avl-asheesh-singh @virtual97 Can you please merge and release this asap? This currently blocks installing the module under Magento 2.4.5-p1.

The corresponding file was introduced with avatax-magento >2.3.0 but even with 2.3.0 I get the following error:

Invalid Document 
Element 'type': Duplicate key-sequence ['ClassyLlama\AvaTax\Model\Tax\Sales\Total\Quote\Tax'] in unique identity-constraint 'uniqueType'.
Line: 311

So I downgraded to 2.2.10 which also has this error. And <2.2.10 is not compatible with Magento >2.4.4.
Your module is currently not installable on Magento 2.4.5-p1 without this change.

@sippsolutions
Copy link
Author

@avl-asheesh-singh this is still relevant under Magento 2.4.6. Please merge this asap.

@IbrahimS2
Copy link

@sippsolutions Indeed, it is a problem, they did not introduce a function to correct existing records so it is aligned with the new requirement.

What is the consequence of truncating the order tables?

@sippsolutions
Copy link
Author

@IbrahimS2 I don't understand what you mean. I'm just referring to pushing the line in the XML into the definition that already exists above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants