Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ronykit added #5359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ronykit added #5359

wants to merge 1 commit into from

Conversation

ehsannm
Copy link

@ehsannm ehsannm commented Jul 15, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

Thanks for your PR, you're awesome! 😎

Copy link

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@yassinebenaid
Copy link
Collaborator

  1. The coverage service link (eg. codecov) is missing.
  2. goreportcard.com link doesn't look to be working.

please read contributing guide

@yassinebenaid
Copy link
Collaborator

Edit 22/24:

Screenshot 2024-07-22 at 10 20 35

Code coverage is low. Some packages (eg. rony) aren't event covered by tests (0%).

@ehsannm
Copy link
Author

ehsannm commented Aug 2, 2024

You are correct about the unit tests. However, the testenv package is used for integration tests. The rony package serves as a wrapper around other packages. Ronykit is a modular framework that allows us to add packages and customize its functionality. The 'std' packages are reference implementations. We plan to add more unit tests in the future, but the system is already in production, stable, and performs well.

TechEmpower Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants