Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving platform.processor and other pylint issue in disk_info.py #2898

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolving platform.processor and other pylint issue in disk_info.py #2898

wants to merge 2 commits into from

Conversation

Naresh-ibm
Copy link
Collaborator

Resolving platform.processor and other pylint issue in disk_info.py

@Naresh-ibm
Copy link
Collaborator Author

Naresh-ibm commented Sep 20, 2024 •
edited
Loading

This is PR is V2 of #2896 Due to file mis-place, I am closing it and re-opened this PR

@Naresh-ibm Naresh-ibm mentioned this pull request Sep 20, 2024
Closed
@Naresh-ibm
Copy link
Collaborator Author

`
Before Fix

00:20:35 INFO : Running Host Tests Suite io_nvme_fvt_disk_info_disk_info
00:20:35 INFO : Running: /usr/local/bin/avocado run --max-parallel-tasks=1 /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py -m /tmp/mux/io_nvme_fvt_disk_info_disk_info.yaml --force-job-id 14ede47e36fc50bf7a1a17a834e636e9a79b0fbb --job-results-dir /root/avocado-fvt-wrapper/results
JOB ID : 14ede47e36fc50bf7a1a17a834e636e9a79b0fbb
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-09-10T00.20-14ede47/job.log
(1/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test_commands;run-filesystem-ext4-5b26: STARTED
(1/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test_commands;run-filesystem-ext4-5b26: CANCEL: Processor is not ppc64 (0.07 s)
(2/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test_commands;run-filesystem-xfs-1398: STARTED
(2/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test_commands;run-filesystem-xfs-1398: CANCEL: Processor is not ppc64 (0.01 s)
(3/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test_commands;run-filesystem-btrfs-4afb: STARTED
(3/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test_commands;run-filesystem-btrfs-4afb: CANCEL: Processor is not ppc64 (0.01 s)
(4/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test;run-filesystem-ext4-5b26: STARTED
(4/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test;run-filesystem-ext4-5b26: CANCEL: Processor is not ppc64 (0.01 s)
(5/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test;run-filesystem-xfs-1398: STARTED
(5/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test;run-filesystem-xfs-1398: CANCEL: Processor is not ppc64 (0.01 s)
(6/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test;run-filesystem-btrfs-4afb: STARTED
(6/6) /root/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/disk_info.py:DiskInfo.test;run-filesystem-btrfs-4afb: CANCEL: Processor is not ppc64 (0.01 s)
RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 6
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-09-10T00.20-14ede47/results.html
JOB TIME : 21.10 s
00:20:59 INFO :

After Fix

avocado run --max-parallel-tasks=1 disk_info.py -m disk_info.py.data/disk_info.yaml

JOB ID : 77616d02cc601f28f85074786cb5d769a4bf88b0
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-09-13T05.07-77616d0/job.log
(1/6) disk_info.py:DiskInfo.test_commands;run-filesystem-ext4-a0d3: STARTED
(1/6) disk_info.py:DiskInfo.test_commands;run-filesystem-ext4-a0d3: PASS (1.27 s)
(2/6) disk_info.py:DiskInfo.test_commands;run-filesystem-xfs-5373: STARTED
(2/6) disk_info.py:DiskInfo.test_commands;run-filesystem-xfs-5373: PASS (0.96 s)
(3/6) disk_info.py:DiskInfo.test_commands;run-filesystem-btrfs-5433: STARTED
(3/6) disk_info.py:DiskInfo.test_commands;run-filesystem-btrfs-5433: CANCEL: btrfs is not supported with RHEL 7.4 onwards (0.02 s)
(4/6) disk_info.py:DiskInfo.test;run-filesystem-ext4-a0d3: STARTED
(4/6) disk_info.py:DiskInfo.test;run-filesystem-ext4-a0d3: PASS (2.76 s)
(5/6) disk_info.py:DiskInfo.test;run-filesystem-xfs-5373: STARTED
(5/6) disk_info.py:DiskInfo.test;run-filesystem-xfs-5373: FAIL: Some tests failed. Details below:\nMismatch in sector sizes of lbs,pbs in lshw o/p w.r.t sysfs paths (3.38 s)
(6/6) disk_info.py:DiskInfo.test;run-filesystem-btrfs-5433: STARTED
(6/6) disk_info.py:DiskInfo.test;run-filesystem-btrfs-5433: CANCEL: btrfs is not supported with RHEL 7.4 onwards (0.02 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 2
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-09-13T05.07-77616d0/results.html
JOB TIME : 36.62 s

Test summary:
5-disk_info.py:DiskInfo.test;run-filesystem-xfs-5373: FAIL
`

PraveenPenguin
PraveenPenguin requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@PraveenPenguin PraveenPenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naresh-ibm thanks for patch , can you please split in 2 commits
1- cpu.get_arch() changes and add other impacted file
2- pylint chnages

@Naresh-ibm
Copy link
Collaborator Author

@Naresh-ibm thanks for patch , can you please split in 2 commits 1- cpu.get_arch() changes and add other impacted file 2- pylint chnages

ok

@Naresh-ibm
adding pylint changes in disk_info.py
2eac6e7 
adding pylint changes in disk_info.py

Signed-off-by: Naresh Bannoth <[email protected]>
@Naresh-ibm
fixing platform.processor issue in disk_info.py
c68d3b6 
Platform.processor() returns Unknown.
Fixing the same using cpu library from avocado utils in disk_info.py

Signed-off-by: Naresh Bannoth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenPenguin PraveenPenguin PraveenPenguin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naresh-ibm @PraveenPenguin