-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset peer and host IP after HTX runs #2904
Reset peer and host IP after HTX runs #2904
Conversation
dee1b22
to
2b89566
Compare
#nohup python avocado-setup.py --run-suite host_io_network_fvt --input-file input.txt & #tail -f nohup.out host_io_network_fvt_htx_nic_devices_HtxNicTest_test_start_htx_nic_devices Run Successfully executed host_io_network_fvt_htx_nic_devices_HtxNicTest_test_check_htx_nic_devices Run Successfully executed host_io_network_fvt_htx_nic_devices_HtxNicTest_test_stop_htx_nic_devices Run Successfully executed host_io_network_fvt_network_test_network_test_virt_net Run Successfully executed |
@vaishnavibhat is this PR related to this #2864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is network configuration needed here ? if htx can take care of ip configurations .. let it .. only flush before and after test ?
Also how will this impact ... htx_start.. htx_check and htx_stop calls in cfg files for scenario cfg ?
io/net/htx_nic_devices.py
Outdated
peer_networkinterface.save(peerip, self.netmask) | ||
except Exception: | ||
peer_networkinterface.save(peerip, self.netmask) | ||
self.ip_addr_remove() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to flush the IP, why to configure in the first place ?... incase to take a backup of ip configuration.. than every test case does configure network before start... so just flush and delete the ips and than let htx configure its own ips.... and at the end of htx again.. flush out the thxips ? am I missing something here ?
io/net/htx_nic_devices.py
Outdated
def htx_cleanup(self): | ||
self.shutdown_htx_daemon() | ||
self.ip_addr_remove() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this as ip_restore already flushes ips
2b89566
to
0ad19b1
Compare
The patch addresses the following: