stress-ng: fix teardown #2910
Merged
stress-ng: fix teardown #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naresh-ibm
requested changes
Oct 23, 2024
generic/stress-ng.py
Outdated
| sudo=True) | ||
| if hasattr(self, 'loop_dev') and os.path.exists(self.loop_dev): | ||
| process.run("umount %s" % self.loop_dev, ignore_status=True, sudo=True) | ||
| process.run("losetup -d %s" % self.loop_dev, ignore_status=True, sudo=True) |
There was a problem hiding this comment.
@disgoel please take care of pep8 errors
# pycodestyle test.py
test.py:80:80: E501 line too long (82 > 79 characters)
test.py:117:80: E501 line too long (81 > 79 characters)
test.py:124:80: E501 line too long (87 > 79 characters)
test.py:173:80: E501 line too long (86 > 79 characters)
test.py:184:80: E501 line too long (86 > 79 characters)
test.py:202:80: E501 line too long (83 > 79 characters)
test.py:203:80: E501 line too long (87 > 79 characters)
Fix the teardown function to prevent AttributeError by adding checks to see if the attribute and path exists before trying to remove it. Before fix: ERROR: 'Stressng' object has no attribute 'loop_dev' ERROR: 'Stressng' object has no attribute 'stressmnt' After fix: CANCEL: Build Failed, Please check the build logs for details !! Signed-off-by: Disha Goel <[email protected]>
disgoel
force-pushed
the
stress-ng-fix
branch
from
a459773
to
8b8766c
Compare
Naresh-ibm
reviewed
Oct 23, 2024
| process.run("rm -rf /tmp/blockfile", ignore_status=True, sudo=True) | ||
| if (os.path.exists(self.stressmnt)): | ||
| process.run(f"rm -rf {self.stressmnt}") | ||
| if hasattr(self, 'stressmnt') and os.path.exists(self.stressmnt): |
There was a problem hiding this comment.
@disgoel is stressmnt and /tmp/blockfile are the same?
if so why are we using variable at one place and hardcoded value at another place?
prefer not to hard code as it may fail if variable name differs
There was a problem hiding this comment.
both are different
self.stressmnt is a directory and /tmp/blockfile is a block device
Naresh-ibm
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the teardown function to prevent AttributeError by adding checks to see if the attribute and path exists before trying to remove it.
Before fix:
ERROR: 'Stressng' object has no attribute 'loop_dev'
ERROR: 'Stressng' object has no attribute 'stressmnt'
After fix:
CANCEL: Build Failed, Please check the build logs for details !!