Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support secrets in render task definition #334

Merged
merged 4 commits into from
Oct 3, 2024
Merged

feat: support secrets in render task definition #334

merged 4 commits into from
Oct 3, 2024

Conversation

kg-aws
Copy link
Contributor

@kg-aws kg-aws commented Oct 3, 2024

Issue #, if available:
#20
Description of changes:
NOTE: This PR is the follow up / rebased version of the PR: #152

Add ability to add secrets to task definition. There is already a pull request here #143 which tries to do this, but it isn't backward compatible. This pull request is. It also doesn't add tests which this PR does.

Thank you @yehudacohen and @hectorgrecco for the initial PR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kg-aws kg-aws requested a review from amazreech October 3, 2024 17:23
@kg-aws kg-aws marked this pull request as ready for review October 3, 2024 17:23
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@kg-aws kg-aws requested a review from amazreech October 3, 2024 19:31
Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kishan, LGTM!

@kg-aws kg-aws merged commit bd39926 into master Oct 3, 2024
6 checks passed
@kurarrr
Copy link

kurarrr commented Oct 13, 2024

It would be appreciated if you could release this nice feature. Thanks in advance!

@Ma-hawaj
Copy link

I see that this feature is released but I'm having issues with it.
I'm using the following:

      - name: Fill in the new image ID in the Amazon ECS task definition
        id: task-def-dev
        uses: aws-actions/[email protected]
        with:
          task-definition-family: dev-chatbot-client-family
          container-name: dev-chatbot-client-container
          secrets: |
            BOT_API_KEY=arn:aws:secretsmanager:***
            BOT_URL=arn:aws:secretsmanager:***
            SUPPORT_CALLBACK_URL=arn:aws:secretsmanager:***
            TABLE_NAME=arn:aws:secretsmanager:***
            COGNITO_CLIENT_ID=arn:aws:secretsmanager:***
            AWS_REGION=arn:aws:secretsmanager:***
          image: '***'

      - name: Show task defenetion
        run: cat ${{ steps.task-def-dev.outputs.task-definition }}

but I'm getting the task definition without any secrets could any one help with that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants