Feat/graph ql transformer core added bracket mismatch detection #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new error that handles whenever the schema has a bracket mismatch ✅ Closes: aws-amplify#107
Added extra validation and more specific error message to address bracket syntax issues in schema ✅ Closes: aws-amplify#107
Added extra error case in case there is an extra bracket in the schema ✅ Closes: aws-amplify#107
Accepted main changes
…-api into feat/graph-ql-transformer-core-added-bracket-mismatch-detection
Added fallback to switch cases as suggested ✅ Closes: aws-amplify#107
add tests for valid, missing bracket, and extra bracket schemas ✅ Closes: aws-amplify#107
Added to the error message the line number in which the bracket mismatch ocurrs ✅ Closes: aws-amplify#107
Update bracket validation function to prevent mismatched brackets inside of comments from throwing error ✅ Closes: aws-amplify#107
Added the case in which there is a bracket mismatch or a hash inside of a string ✅ Closes: aws-amplify#107
Removed useless condition pointed out by lgtm ✅ Closes: aws-amplify#107
Refactored bracket mismatch cases ✅ Closes: aws-amplify#107
…-api into feat/graph-ql-transformer-core-added-bracket-mismatch-detection
Fixed a border case in which # ["asdf"] was not a valid line ✅ Closes: aws-amplify#107
|
I think you need to rebase your changes with |
Added extra validation and more specific error message to address bracket syntax issues in schema ✅ Closes: aws-amplify#107
Added extra error case in case there is an extra bracket in the schema ✅ Closes: aws-amplify#107
Added fallback to switch cases as suggested ✅ Closes: aws-amplify#107
Added to the error message the line number in which the bracket mismatch ocurrs ✅ Closes: aws-amplify#107
Update bracket validation function to prevent mismatched brackets inside of comments from throwing error ✅ Closes: aws-amplify#107
Fixed a border case in which # ["asdf"] was not a valid line ✅ Closes: aws-amplify#107
…etection' of https://github.com/ncarvajalc/amplify-category-api into feat/graph-ql-transformer-core-added-bracket-mismatch-detection
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added border case for feature added in #107 in which this line was not valid:
Issue #, if available
#107
Description of how you validated changes
Modified existing test case and
yarn testsuccesfully.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.