-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new construct AmplifyDatabaseCluster #2969
Open
dpilch
wants to merge
32
commits into
feature/aurora-serverless
Choose a base branch
from
database-construct
base: feature/aurora-serverless
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
database-construct
branch
from
October 22, 2024 16:53
e170748
to
1d2768e
Compare
dpilch
force-pushed
the
database-construct
branch
from
October 24, 2024 15:34
1d2768e
to
6b8ddff
Compare
dpilch
force-pushed
the
database-construct
branch
from
October 25, 2024 14:44
d0c0fa9
to
9cc69e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add new package
@aws-amplify/database-construct
with new constructAmplifyDatabaseCluster
for creating an Aurora database cluster. The final naming and API has not been decided.AmplifyDatabaseClusterProps
Resources
The
resources
property will contain the resources created by the L3 construct.resources.consoleSecret
- Secrets manager secret.resources.dataApiSecret
- Secrets manager secret.resources.databaseCluster
- Aurora cluster.Datasource Strategy
The
datasourceStrategy
property will contain the datasource strategy to be passed to the Amplify GraphQL API construct. The datasource strategy is currently usingSQLLambdaModelDataSourceStrategy
for the PoC, but will change in the future.Usage
CDK / CloudFormation Parameters Changed
See description above. No change to GraphQL API construct yet.
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.