chore: remove @aws-cdk/assert from data-construct, api-construct, and transformer-core
#3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyu99
changed the title
data-construct, api-construct, and transformer-coredata-construct, api-construct, and transformer-core
bobbyu99
changed the title
data-construct, api-construct, and transformer-core@aws-cdk/assert from data-construct, api-construct, and transformer-core
atierian
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Let's remove it from the root package as well.
amplify-category-api/package.json
Line 132 in 37dd5a6
amplify-category-api/package.json
Line 279 in 37dd5a6
atierian
approved these changes
Dec 20, 2024
Siqi-Shan
approved these changes
Dec 20, 2024
bobbyu99
added a commit
that referenced
this pull request
Dec 23, 2024
* chore: update .jsii assembly * chore: update .jsii assembly * ci: remove unused codeql config (#3079) * docs: update readme for gen 2 (#3080) * chore(deps-dev): bump jsii from 5.6.0 to 5.6.4 (#3082) * chore(deps-dev): bump jsii from 5.6.0 to 5.6.4 Bumps [jsii](https://github.com/aws/jsii-compiler) from 5.6.0 to 5.6.4. - [Release notes](https://github.com/aws/jsii-compiler/releases) - [Changelog](https://github.com/aws/jsii-compiler/blob/main/releases.json) - [Commits](aws/jsii-compiler@v5.6.0...v5.6.4) --- updated-dependencies: - dependency-name: jsii dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * chore: regenerate .jsii Signed-off-by: Kevin Shan <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Kevin Shan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Shan <[email protected]> * chore: remove `@aws-cdk/assert` from `data-construct`, `api-construct`, and `transformer-core` (#3089) * chore: remove @aws-cdk/assert dep * chore: updated dependency licenses * chore: removed `@aws-cdk/assert` dep from root `package.json` * chore: remove `cfnspec` and `cloudformation` deps * chore: suppress reexport and type-only files from coverage metrics in @aws-amplify/graphql-category-api (#3087) * fix: remove transitive dev dependencies from bundled jsii constructs (#3092) * remove transitive dev dependencies from jsii constructs * update jsii * update yarn.lock * update dep licenses --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Kevin Shan <[email protected]> Co-authored-by: amplify-data-ci <[email protected]> Co-authored-by: Dane Pilcher <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Shan <[email protected]> Co-authored-by: Tim Schmelter <[email protected]> Co-authored-by: Ian Saultz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
@aws-cdk/assertdependency indata-construct,api-construct, andtransformer-coreis causingnpm run check:dependenciesto fail in the backend repo, throwingIt does not make sense to install
jestin the backend as they don't usejestframework, so it makes more sense to remove@aws-cdk/assertdependency if it is not needed in api repo and its removal does not break anything in api repo.Description of how you validated changes
Validate api-construct is compatible with amplify-backendworkflow to verify that the above changes passnpm run check:dependenciesin the backend repoyarn testpassesChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.