Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declare aws crypto package as a dependency for auth lib, #13024 #13950

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

declare aws crypto package as a dependency for auth lib, #13024 #13950

wants to merge 2 commits into from

Conversation

josefaidt
Copy link
Contributor

Description of changes

declares AWS crypto as a dependency for auth package where it is consumed
https://github.com/aws-amplify/amplify-js/blob/main/packages/auth/src/providers/cognito/utils/oauth/generateCodeVerifier.ts#L4

Issue #, if available

fixes #13024

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cwomack cwomack mentioned this pull request Oct 23, 2024
Open
3 tasks
@josefaidt josefaidt marked this pull request as ready for review October 23, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotwal skotwal skotwal approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@haverchuck haverchuck Awaiting requested review from haverchuck

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

@HuiSF HuiSF Awaiting requested review from HuiSF HuiSF is a code owner

@sktimalsina sktimalsina Awaiting requested review from sktimalsina sktimalsina is a code owner

@pranavosu pranavosu Awaiting requested review from pranavosu pranavosu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to resolve "@aws-crypto/sha256-js" from generateCodeVerifier.ts (random)
3 participants
@josefaidt @AllanZhengYP @skotwal