Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoiding signing out users when the token refresh fails due to no connectivity #104

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Dec 13, 2024

Issue #, if available:

Description of changes:

This PRs fixes the issue when the access token is expired on launch but the device has no connectivity.
Instead of just signing out the user, we'll keep them signed in. This is only done when the user was already signed in.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ruisebas ruisebas marked this pull request as ready for review December 13, 2024 20:33
@ruisebas ruisebas requested a review from a team as a code owner December 13, 2024 20:33
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.39%. Comparing base (a18f030) to head (563315b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rces/Authenticator/Models/AuthenticatorState.swift 0.00% 7 Missing ⚠️
...henticator/Extensions/AuthError+Connectivity.swift 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   44.46%   44.39%   -0.07%     
==========================================
  Files          43       44       +1     
  Lines        2456     2462       +6     
==========================================
+ Hits         1092     1093       +1     
- Misses       1364     1369       +5     
Flag Coverage Δ
Authenticator 44.39% <63.63%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thisisabhash
thisisabhash previously approved these changes Dec 13, 2024
harsh62
harsh62 previously approved these changes Dec 16, 2024
@harsh62
Copy link
Member

harsh62 commented Dec 16, 2024

@ruisebas You can update the change log too, so that we don't need another PR for that..

@ruisebas ruisebas dismissed stale reviews from harsh62 and thisisabhash via 563315b December 16, 2024 16:12
@ruisebas ruisebas merged commit fd86328 into main Dec 16, 2024
5 checks passed
@ruisebas ruisebas deleted the ruisebas/fix-refresh-offline branch December 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants