feat: remove dependency on amplifyconfiguration.json #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
requested changes
Mar 13, 2024
| self.cognito = CognitoConfiguration( | ||
| usernameAttributes: configuration.usernameAttributes, | ||
| signupAttributes: configuration.signUpAttributes, | ||
| passwordProtectionSettings: configuration.passwordProtectionSettings ?? .init(minLength: 0, characterPolicy: []), |
There was a problem hiding this comment.
❗ This is a change in existing behaviour. Currently, the Authenticator requires these password settings to be explicitly set, showing an error if that is not the case.
But now we will just default to not having password validations.
I don't feel strongly against this, but I think Android also requires these values so we should coordinate to make the change there as well. And also call it out in the release notes
There was a problem hiding this comment.
Great callout, will follow up on this
9 tasks
ruisebas
requested changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR includes the changes that no longer depend on
jsonConfigurationto get the auth configuration values. This PR needs to be updated with a version upgrade on the Amplify dependency to get theauthConfigurationchanges at the same time. It depends on this PR to be merged and released first: aws-amplify/amplify-swift#3566By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.