Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding regex based exports replacement #1049

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

ammokhov
Copy link
Contributor

@ammokhov ammokhov commented Dec 20, 2023

Issue #, if available:

Description of changes:

Adding a regex based exports replacement, as it is a less expensive manipulation. The change finds {{ variable }} pattern that jinja supports but verifies that variable is compliant with stack export naming convention.

Example:

overrides.json

{
    "CREATE": {
        "/SubnetId": "{{ subnetID }}"
    }
}

rendered overrides.json

{
    "CREATE": {
        "/SubnetId": "subnet-0bc6136e"
    }
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov ammokhov merged commit 5306687 into aws-cloudformation:master Dec 20, 2023
12 checks passed
@ammokhov ammokhov deleted the stub-exports branch December 20, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants