Adding headers in STS Calls for Confused Deputy #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
approved these changes
Mar 7, 2024
ericzbeard
reviewed
Mar 7, 2024
| @@ -23,4 +24,5 @@ indent-string=' ' | |||
| max-line-length=160 | |||
There was a problem hiding this comment.
Can we add an exception to just the one line if it's not possible to break it down? 160 is very long.
There was a problem hiding this comment.
This exception is from a different PR(PR No:663).
https://github.com/aws-cloudformation/cloudformation-cli/pull/663/files#diff-ba293004ae8f18975051e825bd8d5c70137a8b5d42d16e0f7c9354aa634c446c
ericzbeard
reviewed
Mar 7, 2024
himanshs23
reviewed
Mar 11, 2024
| params["headers"]["x-amz-source-arn"] = headers["source_arn"] | ||
|
|
||
| sts_client.meta.events.register("before-call", inject_confused_deputy_headers) | ||
| LOG.info(headers) |
There was a problem hiding this comment.
do we need to still log it
himanshs23
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding headers in STS Calls for Confused Deputy to accept account id and the source ARN
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.