Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpr validations to cfn validate with supporting tests. #1097

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

syldyer
Copy link
Contributor

@syldyer syldyer commented Oct 8, 2024

Issue #, if available:

These changes are made as part of Registration Improvement efforts.

Description of changes:
This pull request is to add validations used in MPR into RPDK for cfn validate, and testing to support the changes.

(There is also a formatting change in generate_docs() that was modified by Black code formatter and does not contribute to any functionality changes)

This includes:

  • checking the size of the RPDK config
  • checking the size of the TypeConfiguration schema
  • checking for a valid protocol version

Validations that were not included are:

  • checks done in Schema Guard Rail
  • checks between the configuration and the request (done during registration)
  • checks for resource type relations (involves server-side calls to describe type)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@syldyer syldyer merged commit a73666d into master Oct 10, 2024
24 checks passed
@syldyer syldyer deleted the rpdk-validations branch October 10, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants