Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CloudWatch Alarms and update X-Ray implementation #577

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

charles-marion
Copy link
Collaborator

@charles-marion charles-marion commented Sep 24, 2024

Issue #, if available:
#502

Description of changes:
Documentation:

  • Re-order the pages order
  • Add Monitoring page
  • Add mention to read security and precautions before deployment.

CloudWatch:

  • Add Cloudfront metrics to the dashboard
  • Add the following alarms:
    • Composite alarm tracking the other alarms
    • Appsync: Latency and fault rate
    • CloudFront: Fault rate
    • SQS: DLQs are empty
    • Step function: Execution failures

AWS X-Ray:

  • Enable traces only if advanced monitoring is enabled
  • Add SNS X-Ray support to track the traces end to end
  • Upgrade X-Ray SDK

AppSync:

  • Change log level to INFO + Set retention based on the config.

Integration test:

  • Remove an assert in embedding_test.py. A model change would make this test flaky.

Testing
Ran integration tests, verified the alarms and the X-Ray traces.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@charles-marion charles-marion merged commit ae337e5 into aws-samples:main Sep 25, 2024
1 check passed
@charles-marion charles-marion deleted the alarms branch September 25, 2024 14:29
lloydclowes pushed a commit to lloydclowes/gen-ai-playground that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants