Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML 認証機能の追加 #309

Merged
merged 10 commits into from
Feb 8, 2024
Merged

SAML 認証機能の追加 #309

merged 10 commits into from
Feb 8, 2024

Conversation

Sugi275
Copy link
Collaborator

@Sugi275 Sugi275 commented Feb 5, 2024

Issue #, if available:
#295
#224

Description of changes:
・SAML 認証機能の追加
・SAML 認証機能に伴い、cdk.json にパラメーターを追加
・Document に Microsoft Entra ID (旧 Azure Active Directory) との詳細な連携 Document を追加

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体コメントとして、saml が有効になっている場合はここも false にした方がセキュリティ的に良いのではないでしょうか?(API を叩けば SignUp できてしまうかも?)
https://github.com/aws-samples/generative-ai-use-cases-jp/blob/main/packages/cdk/lib/construct/auth.ts#L29

### SAML 認証

Microsoft Entra ID (旧 Azure Active Directory) などの IdP が提供する SAML 認証機能と連携ができます。
[こちらに Microsoft Entra ID と SAML 設定を行う参考手順](SAML_WITH_ENTRA_ID.md) があります。Microsoft Entra ID の設定を含めた詳細な手順があるので、こちらもご活用ください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分けたの素晴らしい判断 👍

![image-20240128114108630](assets/SAML_WITH_ENTRA_ID/image-20240128114108630.png)

# Cognito の設定 : Domain 設定
Cogitno domain の設定を進めます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cognito のタイポ

![image-20240205185602299](assets/SAML_WITH_ENTRA_ID/image-20240205185602299.png)


Identity Provider で Entra ID を選択します。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cognito user pool は外した方が良いですね

) : !authenticated ? (
<div className="grid grid-cols-1 gap-4 justify-items-center">
<Text className="text-center text-3xl mt-12">
Generative AI on AWS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他と統一して Generative AI Use Cases on AWS にしましょうか。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、従来の User Pool 認証 (非 SAML) のほうでも「Generative AI on AWS」となっていたので、「Generative AI Use Cases on AWS」に変更しておきます!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合わせていただいたんですね!:+1: Use Cases あり版にしていただければ :pray:

@Sugi275
Copy link
Collaborator Author

Sugi275 commented Feb 7, 2024

全体コメントとして、saml が有効になっている場合はここも false にした方がセキュリティ的に良いのではないでしょうか?(API を叩けば SignUp できてしまうかも?) https://github.com/aws-samples/generative-ai-use-cases-jp/blob/main/packages/cdk/lib/construct/auth.ts#L29

以下のように SAML を利用する場合はセルフサインアップを無効化するように CDK コードを修正しました。

https://github.com/aws-samples/generative-ai-use-cases-jp/pull/309/files#diff-4d26443f265824b352e6956f66051e51fd61dde7238ff8a91e1375c7e793c350R30-R31

@tbrand tbrand merged commit 3669c69 into main Feb 8, 2024
1 check passed
@tbrand tbrand deleted the saml-federation branch February 8, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants