ファイルアップロード機能 #318
Merged
ファイルアップロード機能 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
reviewed
Feb 13, 2024
gteu
commented
Feb 14, 2024
| commonAuthorizerProps | ||
| ); | ||
|
|
||
| // REST API の Method で VPC Link を参照すると、正しく削除できない問題がある。 |
There was a problem hiding this comment.
PR を作成した段階のコードだと、VPC Link の削除時にエラーが出ることが判明したので、それを回避するために以下の実装を加えています。
|
レビューありがとうございます。 |
tbrand
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#147
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.