自動翻訳、自動校正の設定が可能に (自動で実行されるのを止めることが可能に) #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
reviewed
Feb 20, 2024
|
|
||
| type Props = BaseProps & { | ||
| checked: boolean; | ||
| onChange: () => void; |
There was a problem hiding this comment.
Input 系のコンポーネントは、onChangeの引数が変更後の値であることが多いと思うので、こちらもそれに合わせてonChange(newValue or Event) => voidの方が自然かなと思いました。
（Switchに関しては反転するだけなので、引数なし�も処理はできますが・・・）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.