画像のドラッグ&ドロップ対応 #384
Merged
画像のドラッグ&ドロップ対応 #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
reviewed
Mar 12, 2024
packages/web/src/pages/ChatPage.tsx
Outdated
| onDrop={handleDrop} | ||
| className="fixed bottom-0 left-0 right-0 top-0 z-40 bg-slate-300 p-10 text-center"> | ||
| <div className="flex h-full w-full items-center justify-center outline-dashed"> | ||
| <div className="font-bold">Drop Files to Upload</div> |
There was a problem hiding this comment.
日本語で構成されているアプリなので、こちらのメッセージも日本語の方が統一感があると思いました！
また、画像ファイルがアップロードできることがわかるメッセージだと親切かと思います。
packages/web/src/pages/ChatPage.tsx
Outdated
| <div | ||
| onDragLeave={handleDragLeave} | ||
| onDrop={handleDrop} | ||
| className="fixed bottom-0 left-0 right-0 top-0 z-40 bg-slate-300 p-10 text-center"> |
There was a problem hiding this comment.
z-40にしている理由はありますか？
こちらは最前面に表示されるべきものだと思うので、z-[999]などのように極端な値を設定していた方が良いです（ぱっと見わかりやすいので）
There was a problem hiding this comment.
ありがとうございます。既存で z-20 まで使われていたので次に大きいものにしていましたが、z-[999] の方がいいですね。修正しました。
maekawataiki
force-pushed
the
feat/image-drop
branch
from
472a29c
to
1c9a6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#367
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.