Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

エラーの回避 Cannot read properties of undefined (reading 'content') #491

Merged
merged 1 commit into from
May 8, 2024
Merged

エラーの回避 Cannot read properties of undefined (reading 'content') #491

merged 1 commit into from
May 8, 2024

Conversation

tbrand
Copy link
Contributor

@tbrand tbrand commented May 8, 2024

  • 楽観的処理の影響で正常に保存できていない会話履歴が存在する可能性がある
  • 現状それを開くと表題のエラーで画面を開けない
  • 少なくとも会話履歴から削除できるように表題のエラーを "回避" (非修正) するようにした
  • これにより不正な画面が表示される可能性はあるが、削除はできるようになった

不正な会話履歴の例

スクリーンショット 2024-05-08 10 52 52

関連 Issue

ただしこれを直接修正する PR ではない (あくまで回避)

wadabee
wadabee approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@wadabee wadabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@wadabee wadabee merged commit ad37882 into main May 8, 2024
2 checks passed
@wadabee wadabee deleted the avoid-content-of-undefined branch May 8, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadabee wadabee wadabee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbrand @wadabee @tbrandaws