Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TranslatePage.tsx #583

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Update TranslatePage.tsx #583

merged 1 commit into from
Jul 31, 2024

Conversation

tbrand
Copy link
Contributor

@tbrand tbrand commented Jul 31, 2024

language がないため、getTranslation 関数が更新されていなかった。

バグ再現手順

  • 翻訳 use case でたまに起こる嫌な挙動の再現方法がわかったので共有です。
  • 翻訳したい文章（日本語）を入力
  • 日本語にセットして実行
  • 想定どおり日本語が日本語に翻訳される
  • 英語にセットしなおして実行
  • 日本語の翻訳結果がまた出てしまう（会話履歴を見ると日本語に翻訳しろ、というのが残ってしまっている）

kazuhitogo
kazuhitogo approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@kazuhitogo kazuhitogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & 動作確認とれました！

@kazuhitogo kazuhitogo merged commit 726a00c into main Jul 31, 2024
2 checks passed
@kazuhitogo kazuhitogo deleted the fix-translate branch July 31, 2024 02:38
@kazuhitogo
Copy link
Collaborator

LGTM!
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuhitogo kazuhitogo kazuhitogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbrand @kazuhitogo