翻訳ユースケース音声再生ボタン + レイアウト改善 #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tbrand
commented
Aug 13, 2024
•
tbrand
commented
- 現状英語に限定 (今後拡張していく)
- 初回再生時に最初の音声が途切れるが、原因不明 (Google 翻訳等でも同じ動作になるので現状修正しない方針ですが、解決策あればやります)
- 再生中にスピーカーボタン停止で再生ストップ (巻き戻し)
- 長い文章をパッと貼った時に実行ボタンが見えなくなってしまうので、「追加コンテキスト」と「実行ボタン・クリアボタン」を左右に分割しました。(下部画像)
tbrand
commented
Aug 14, 2024
| @@ -283,7 +330,7 @@ const TranslatePage: React.FC = () => { | |||
| </div> | |||
| <div className="flex w-full flex-col lg:flex-row"> | |||
| <div className="w-full lg:w-1/2"> | |||
| <div className="flex items-center py-2.5"> | |||
| <div className="flex h-12 items-center"> | |||
There was a problem hiding this comment.
上部がずれていたので合うようにサイズ固定にしました
wadabee
requested changes
Aug 19, 2024
Comment on lines
287
to
297
| // 再生中の場合は止める | ||
| if (isSpeachPlaying && audioRef.current) { | ||
| audioRef.current.pause(); | ||
| audioRef.current.currentTime = 0; | ||
| setIsSpeachPlaying(false); | ||
| return; | ||
| } | ||
|
|
||
| const speachUrl = await synthesizeSpeach(translatedSentence); | ||
|
|
||
| setIsSpeachPlaying(true); |
There was a problem hiding this comment.
スピーカーボタンを連打すると、重複してPollyが実行されて、音声が連打した分だけ再生されるので、ボタンを押した瞬間にフラグを更新した方が良さそうです！
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.