Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS CloudShell を利用したデプロイ方法の確立 #669

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

tbrand
Copy link
Contributor

@tbrand tbrand commented Oct 1, 2024

No description provided.

@tbrand tbrand changed the title [WIP] AWS CloudShell を利用したデプロイ方法の確立 AWS CloudShell を利用したデプロイ方法の確立 Oct 1, 2024
Copy link
Contributor

@wadabee wadabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点ご確認をお願いします!

また、ダウンロード後に deploy.sh に実行権限を付与しています。

```bash
wget https://raw.githubusercontent.com/aws-samples/generative-ai-use-cases-jp/refs/heads/main/deploy.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-O deploy.sh のオプションがあった方が良いかなと思いました!
CloudShellの環境が初期化されていない状態で実行すると、古いdeploy.shが実行されることもあるのかなーと(レアパターンですが。。)

Copy link
Contributor

@wadabee wadabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wadabee wadabee merged commit e315abb into main Oct 2, 2024
2 checks passed
@wadabee wadabee deleted the deploy-on-cloudshell branch October 2, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants