Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

会話件名の更新 #73

Merged
merged 3 commits into from
Sep 22, 2023
Merged

会話件名の更新 #73

merged 3 commits into from
Sep 22, 2023

Conversation

wadabee
Copy link
Contributor

@wadabee wadabee commented Sep 21, 2023

Issue #, if available:
#70 #40

Description of changes:

楽観的更新(APIのレスポンスを待たずに画面を更新。エラー時は画面表示をロールバック)の手法で実装しました。
削除も同様の実装にしたため、ローディング表示対応は不要になると思います。

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wadabee wadabee requested a review from tbrand September 21, 2023 09:53
@wadabee wadabee changed the title Update chat title 会話件名の更新 Sep 21, 2023
Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tbrand tbrand merged commit 9bd949a into main Sep 22, 2023
1 check passed
@tbrand tbrand deleted the update-chat-title branch September 22, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants