会話履歴のページは header にタイトルを出すようにする #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
reviewed
Oct 4, 2023
packages/web/src/App.tsx
Outdated
Comment on lines
90
to
98
| useEffect(() => { | ||
| setLabel(getLabelByPath(pathname)); | ||
| }, [pathname]); | ||
| const chatId = extractChatId(pathname); | ||
|
|
||
| if (chatId) { | ||
| setLabel(getConversationTitle(chatId) || ''); | ||
| } else { | ||
| setLabel(items.find((i) => i.to === pathname)?.label || ''); | ||
| } | ||
| }, [pathname, getConversationTitle]); |
There was a problem hiding this comment.
以下のエラーが発生しているようです。
Labelを設定するだけの処理なので、useMemoでラベルを返す感じでもいいかなと思いました！
App.tsx:94 Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60