Adding apigw-sfn-crud-terraform pattern #2444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfreiberg
requested changes
Oct 8, 2024
There was a problem hiding this comment.
I get an error when running `terraform apply´ due to CloudWatch Logs ARN not being specified. Please add instructions or link to documentation on how to do this.
│ Error: error updating API Gateway Stage (ags-6omth9g63d-Prod): BadRequestException: CloudWatch Logs role ARN must be set in account settings to enable logging
│
│ with aws_api_gateway_stage.API_SF_CRUD-tf_API_Stage_Prod,
│ on main.tf line 222, in resource "aws_api_gateway_stage" "API_SF_CRUD-tf_API_Stage_Prod":
│ 222: resource "aws_api_gateway_stage" "API_SF_CRUD-tf_API_Stage_Prod" {
| required_providers { | ||
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = "~> 3.27" |
There was a problem hiding this comment.
Please use the most recent version
| resource "aws_sfn_state_machine" "API_SF_CRUD-tf_CF" { | ||
| name = "API_SF_CRUD-tf_CF" | ||
| role_arn = aws_iam_role.API_SF_CRUD-tf_CFRole.arn | ||
| definition = file("./crud.asl.json") |
There was a problem hiding this comment.
File is named crud-asl.json
bfreiberg
reviewed
Oct 8, 2024
|
|
||
| ## How it works | ||
|
|
||
| Amazon API Gateway creates a direct integration with AWS Step Functions utilizing a synchronous call. Step functions evaluates the path and method to choose the proper action. The action steps can be modified to meet your needs. |
There was a problem hiding this comment.
Suggested change
| Amazon API Gateway creates a direct integration with AWS Step Functions utilizing a synchronous call. Step functions evaluates the path and method to choose the proper action. The action steps can be modified to meet your needs. | |
| Amazon API Gateway creates a direct integration with AWS Step Functions utilizing a synchronous call. The Step Functions state machine evaluates the path and method to choose the proper action. The action steps can be modified to meet your needs. |
bfreiberg
reviewed
Oct 8, 2024
|
|
||
| *CRUD = Create, Read, Update, Delete* | ||
|
|
||
| Once the application is deployed, use a tool like Postman or Curl to call the different CRUD endpoints. If you would like to import the Postman package, update the endpoint and import into Postman. |
There was a problem hiding this comment.
It isn't clear to me what is meant be updating the endpoint and importing it? Please also add an example of a curl request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2443
Description of changes:
Adding terraform version of apigw-sfn-crud pattern
https://serverlessland.com/patterns/apigw-sfn-crud
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.