fix: handle transaction sql with comments at the beginning #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congoamz
reviewed
Sep 26, 2022
| () -> this.pluginService.getCurrentConnection().setAutoCommit(autoCommit), | ||
| () -> { | ||
| this.pluginService.getCurrentConnection().setAutoCommit(autoCommit); | ||
| this.pluginManagerService.setInTransaction(true); |
There was a problem hiding this comment.
should this be setInTransaction(!autoCommit)? We could be setting autoCommit to true, in which case we wouldn't be in a transaction
There was a problem hiding this comment.
Good catch, thanks
karenc-bq
force-pushed
the
transaction_status
branch
from
a50fdc4
to
69a76b0
Compare
karenc-bq
changed the title
|
Thanks, looks good |
congoamz
approved these changes
Sep 27, 2022
karenc-bq
added a commit
that referenced
this pull request
Sep 28, 2022
- handle transaction SQL statements with comments at the beginning, e.g. `\*comment*\ begin;` - set transaction status in `setAutoCommit`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix some bugs around code detecting whether the session is in a transaction
#160
Github Actions are failing due to a flaky test, the fix for that test is in #164
Description
\*comment*\ begin;setAutoCommitAdditional Reviewers
@congoamz
@joyc-bq
@davecramer
@alecc-bq